Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/breaking: simplify scalar types #1388

Merged
merged 6 commits into from
Sep 29, 2023
Merged

chore/breaking: simplify scalar types #1388

merged 6 commits into from
Sep 29, 2023

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Sep 28, 2023

Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.

Checklist

  • Ensure your top-level commit message is in line with our contributor guidelines.
  • Please add proper labels.
  • If there is an issue associated with this PR, please link the issue (right-hand sidebar)
  • If there is not an issue associated with this PR, add this PR to the "Fuel Indexer" project (right-hand sidebar)
  • Please allow Codeowners at least 24 hours to do a first-pass review.
  • Please add thoroughly detailed testing steps below.
  • Please keep your Changelog message short and sweet.

Description

  • PR simplifies our usage of scalars
  • We had a lot of scalars that we weren't really using
    • I think previously the idea was to "alias things in a friendly way", but aliasing turned out to just generate a lot of unnecessary scalars
    • After some time, I think it's better to have fewer scalars
      • This was first suggested by JC (which I agreed with)
  • Also changes the name of some scalars to make them more idiomatic
    • E.g., Int8 to I64 to be more in line with GraphQL standards (obviously we're still using types that GQL doesn't implement)
  • Obviously this is a pretty breaking change
    • I'll be sure to include a prominent section in the release changelog for this

Testing steps

  • CI should pass
  • QA run report is attached

Changelog

  • chore/breaking: simplify scalar types

@ra0x3 ra0x3 self-assigned this Sep 28, 2023
@ra0x3 ra0x3 added the breaking This is a change that will break some component of the project once merged to origin/develop label Sep 28, 2023
@ra0x3 ra0x3 changed the title chore: simplify scalar types chore/breaking: simplify scalar types Sep 28, 2023
@ra0x3
Copy link
Contributor Author

ra0x3 commented Sep 28, 2023

QA script results on this branch
Rashads-Air.lan-2023-09-28.indexer-qa.txt

@ra0x3 ra0x3 merged commit f02438a into develop Sep 29, 2023
19 checks passed
@ra0x3 ra0x3 deleted the rashad/cleanup-scalars branch September 29, 2023 14:52
@ra0x3 ra0x3 mentioned this pull request Oct 10, 2023
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a change that will break some component of the project once merged to origin/develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants