fix: support contract JSON ABI with callpaths #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekerno
force-pushed
the
deekerno/support-abi-with-callpath
branch
from
e785cd3
to
3b5026d
Compare
ra0x3
approved these changes
Sep 18, 2023
lostman
approved these changes
Sep 19, 2023
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1320.
Description
Adds support for JSON ABIs that have callpaths in the
typefield.Testing steps
The
fuel-indexer-testcontract ABI has been re-generated withforc build --json-abi-with-callpathsand CI should pass.Manual testing
On
develop:forc buildto get a regular JSON ABI. Attempt to build the corresponding indexer for that contract. It should succeed. 🟢forc build --json-abi-with-callpathsto generate a JSON ABI with callpaths included. Attempt to build the corresponding indexer for that contract. It should fail. 🔴On this branch:
forc buildto get a regular JSON ABI. Attempt to build the corresponding indexer for that contract. It should succeed. 🟢forc build --json-abi-with-callpathsto generate a JSON ABI with callpaths included. Attempt to build the corresponding indexer for that contract. It should also succeed. 🟢