Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all panic and expect from executor codepaths #1098

Closed
ra0x3 opened this issue Jul 12, 2023 · 0 comments · Fixed by #1395
Closed

Remove all panic and expect from executor codepaths #1098

ra0x3 opened this issue Jul 12, 2023 · 0 comments · Fixed by #1395
Assignees

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Jul 12, 2023

  • A more comprehensive follow up to Invalid encoded byte error on beta-3-indexer #1096
  • We have some panic and expect floating all around the tokio executor codepaths
  • This is fine for debugging, but on production this will cause the service to crash
  • Regardless of the case, in these executor codepaths, even if the operation fails, it needs to fail gracefully so the service can continue running
  • If we encounter weirdness, we need to log it and keep moving
  • Panic/except ok for when the service is started, but any codepath hit by a running tokio executor needs to be guarded

Additional context

  • Some codepaths to possibly update
    • fuel_indexer::database
    • fuel_indexer::ffi
    • fuel_indexer::executor
    • fuel_indexer_schema::db::tables
    • fuel_indexer_schema::manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants