Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep record of events from L1 in Block Header #1769
Keep record of events from L1 in Block Header #1769
Changes from all commits
36fc1ec
a94e8bb
dd6b0ca
9402921
8eb2714
f6e6e22
95663d4
c069557
99cddf3
646cfbf
54de938
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm curious: does Ethereal RPC guarantee that the order of events is the same as they were emitted? @MitchTurner , Could you double-check that?=)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at ethers, there is a field for indexing fields within each block. We could sort all the logs by this in the relayer to play it safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also consider lexicographically sorting all the event hashes before merklizing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order we receive the events shouldn't be dependent on the Ethereal RPC specifically, rather our implementation of
Relayer
as a whole.IF the order isn't deterministic, then I agree with @Voxelot that we could just do some deterministic sorting in our
Relayer
adapter.Do we want to do that as part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we could just order them after we get them from the
Relayer
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best ordering Imo is to use log_index, as it ensures fair ordering of event processing. I'd prefer to avoid muddling our events in the executor with ethereum specific fields, so I'd be fine with making a separate PR to ensure ordering on the relayer side.
The alternative is to add some kind of ordering field to events, and making the executor sort them every time. However, this would also incur additional consensus overhead which I think we could avoid.