Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forward compatibility test for fuel-core 0.36.0 #2198

Closed
xgreenx opened this issue Sep 15, 2024 · 2 comments
Closed

Add forward compatibility test for fuel-core 0.36.0 #2198

xgreenx opened this issue Sep 15, 2024 · 2 comments
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Sep 15, 2024

After release of fuel-core 0.36.0 we need to add forward compatibility test for it.

image
@acerone85
Copy link
Contributor

I'm happy to have a look at this one after 0.36.0 is released

xgreenx added a commit that referenced this issue Sep 17, 2024
…2199)

Closes #1887
Closes FuelLabs/fuel-vm#797
Related #2114
Related #2133

This PR contains several small breaking changes to the WASM interface:
- Get the module to execute WASM byte code from the storage first, an
fallback to the built-in version in the case of the
`FUEL_ALWAYS_USE_WASM`.
- Added `host_v1` with a new `peek_next_txs_size` method, that accepts
`tx_number_limit` and `size_limit`.
- Added new variant of the return type to pass the validation result. It
removes block serialization and deserialization and should improve
performance.
- Added a V1 execution result type that uses `JSONError` instead of
postcard serialized error. It adds flexibility of how variants of the
error can be managed. More information about it in
FuelLabs/fuel-vm#797. The change also moves
`TooManyOutputs` error to the top. It shows that `JSONError` works as
expected.
- Use a WASM generated bytecode for the local testnet since we always
want to use the latest version compatible with native execution.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here
    - #2198
    - #2200

---------

Co-authored-by: Rafał Chabowski <88321181+rafal-ch@users.noreply.github.com>
Co-authored-by: Hannes Karppila <2204863+Dentosal@users.noreply.github.com>
@rafal-ch rafal-ch self-assigned this Sep 24, 2024
rafal-ch added a commit that referenced this issue Oct 5, 2024
Closes #2198.

## Description
This test upgrades the forward compatibility test by replacing the
"genesis" nodes (which used v0.26) with the nodes that use v36 of the
client.

It also adds one backward compatibility test:
`latest_binary_is_backward_compatible_and_follows_blocks_created_by_v36_binary()`

### Before requesting review
- [X] I have reviewed the code myself

---------

Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
@rafal-ch
Copy link
Contributor

Closed with #2271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants