-
Notifications
You must be signed in to change notification settings - Fork 0
feat: init fuel-telemetry #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR SummaryIntroduces telemetry support across forc crates and refactors tracing initialization for proper lifecycle handling.
Written by Cursor Bugbot for commit 9c5d1a2. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| .and_then(|silent| silent.then_some(LevelFilter::OFF)) | ||
| }); | ||
| }) | ||
| .unwrap_or(LevelFilter::INFO); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUST_LOG level settings overridden by default INFO filter
Medium Severity
The level_filter now defaults to LevelFilter::INFO via .unwrap_or(LevelFilter::INFO) and is always applied via .with_filter(level_filter). Previously, when no CLI verbosity options were set, level_filter was None and with_max_level was not called, allowing RUST_LOG to control log levels. Now, setting RUST_LOG=debug without CLI flags results in only INFO+ logs since both filters are ANDed together and the stricter one wins.
Additional Locations (1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good one will address
Re-enabling tracing, it was problematic in the past because of how we integrated this. Little bit more details:
The
WorkerGuardfrom fuel-telemetry was stored in a staticOnceLockinforc-tracing, preventing its Drop implementation from running. This caused, zombie processes remaining after CLI tool executionRefactored
init_tracing_subscriber()to return the WorkerGuard to the caller, enabling proper RAII cleanup when programs exit.