Test PHP 7.3 and 7.4 #224
Merged
Test PHP 7.3 and 7.4 #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alse on newer versions and is deprecated since PHP 7.4
alquerci
reviewed
Mar 23, 2020
lib/request/sfWebRequest.class.php
Outdated
|
|
||
| // GET parameters | ||
| $this->getParameters = get_magic_quotes_gpc() ? sfToolkit::stripslashesDeep($_GET) : $_GET; | ||
| if (version_compare(PHP_VERSION, '5.4', '<') && get_magic_quotes_gpc()) |
There was a problem hiding this comment.
I recommend to use 7.4.0-dev instead of 7.4.
Note that pre-release versions, such as 5.3.0-dev, are considered lower than their final release counterparts (like 5.3.0).
source https://www.php.net/manual/en/function.version-compare.php
There was a problem hiding this comment.
@alquerci you mean 5.4.0-dev, right? :)
There was a problem hiding this comment.
Ha, yes.
I through that patch is related to PHP 7.4 support. :)
There was a problem hiding this comment.
Thank you for the hint. Adjusted to 5.4.0-dev
|
I don't make a point in having my PR in — this one does the same and beyond 👍— I'll close #216 . |
j0k3r
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_magic_quotes_gpc()only for PHP < 5.4. It always returned false since PHP 5.4 and is deprecated since PHP 7.4