Backport fix for cve-2019-18888 #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alquerci
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
Hello @adrienperonnet,
Thank you for this security fix, but there is one patch to do.
See the line comment.
👎
alquerci
approved these changes
Nov 27, 2019
j0k3r
approved these changes
Apr 3, 2020
j0k3r
added a commit
that referenced
this pull request
Apr 3, 2020
terdia
pushed a commit
to amboss-mededu/php-symfony1
that referenced
this pull request
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guessFromFileBinarymay also be impacted by cve-2019-18888 wherethe provided file paths were not being properly escaped before being used.
This PR backports the fix from commit symfony/symfony@691486e to make sure the issue is not exploitable.