Allow to disable SwiftMailer for real #17
Merged
+88
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow to avoid SwiftMailer initialization on all requests even if the application does not send any email.
GromNaN
added a commit
that referenced
this pull request
Aug 19, 2013
Allow to disable SwiftMailer for real by using sfNoMailer
Collaborator
|
Thanks. Excellent PR 🌹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now completely disable SwiftMailer (which is initialized on each request by default) by using the new
sfNoMailerclass in your factories.yml:This code was sleeping on my computer - but it has been tested on some major customer websites. When dealing with emails via a service provider, RabbitMQ, or no email at all... Symfony is still creating instance of SwiftMailer. This is nuts, here is the fix for that.