Apply NotBlank only to the whole array #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Dec 11, 2018
| } | ||
| } | ||
|
|
||
| if (false === $this->allowBlank) { |
There was a problem hiding this comment.
I think my suggestion in #1769 was not good either. Keeping the constraint on line 59 is probably necessary so that it will be applied to the nested data. Though applying it to the collection itself does not make much sense IMO (and we also have the NotNull constraint).
There was a problem hiding this comment.
So should we just keep the NotNull additionnal check? I think it would make sense, I'm updating it pending your answer :)
xabbuh
approved these changes
Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/FriendsOfSymfony/FOSRestBundle/pull/1769/files/da8d1ff7d91e5e178022b82a206eacf9b604f3b1#r231027007