manually decorate the core JMS handler registry #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find @xabbuh Just one more test needs to be resolved:
|
This works around the fact that custom handlers are processed in JMSSerializerBundle after Symfony's DecoratorServicePass has been executed (which means that we cannot use proper service decoration). The old code still used to work on Symfony 2.x applications where FOSRestBundle was registered after JMSSerializerBundle. In those cases, custom handlers were processed before the handler registry was replaced by the compiler pass coming from FOSRestBundle. More recent Symfony applications have not been affected by this bug as the compiler pass priority would have ensured the correct order in which the passes would have been executed.
|
@XWB here we go 🎉 |
|
All green 🎉 |
xabbuh
added a commit
that referenced
this pull request
Feb 27, 2018
This PR was merged into the 2.3-dev branch. Discussion ---------- manually decorate the core JMS handler registry This works around the fact that custom handlers are processed in JMSSerializerBundle after Symfony's DecoratorServicePass has been executed (which means that we cannot use proper service decoration). The old code still used to work on Symfony 2.x applications where FOSRestBundle was registered after JMSSerializerBundle. In those cases, custom handlers were processed before the handler registry was replaced by the compiler pass coming from FOSRestBundle. More recent Symfony applications have not been affected by this bug as the compiler pass priority would have ensured the correct order in which the passes would have been executed. Commits ------- 17c8de8 manually decorate the core JMS handler registry
This was referenced Feb 27, 2018
|
Does this fix #1851? |
|
@Tobion yes, updating to 2.3.1 should help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the fact that custom handlers are processed in
JMSSerializerBundle after Symfony's DecoratorServicePass has been
executed (which means that we cannot use proper service decoration).
The old code still used to work on Symfony 2.x applications where
FOSRestBundle was registered after JMSSerializerBundle. In those cases,
custom handlers were processed before the handler registry was replaced
by the compiler pass coming from FOSRestBundle.
More recent Symfony applications have not been affected by this bug as
the compiler pass priority would have ensured the correct order in which
the passes would have been executed.