JMSHandlerRegistry must implements HandlerRegistryInterface correctly

[timotheemoulin]

Hello all,

In the latest version of JMS\Serializer the class JMS\Serializer\Handler\HandlerRegistryInterface defines registerSubscribingHandler and registerHandler as void functions thus JMSHandlerRegistry implementation must follow the same definition and not return anything.

public function registerSubscribingHandler(SubscribingHandlerInterface $handler): void;
public function registerHandler(int $direction, string $typeName, string $format, $handler): void;

versus

 /**
 * {@inheritdoc}
 */
public function registerSubscribingHandler(SubscribingHandlerInterface $handler)
{
    return $this->registry->registerSubscribingHandler($handler);
}

/**
 * {@inheritdoc}
 */
public function registerHandler($direction, $typeName, $format, $handler)
{
    return $this->registry->registerHandler($direction, $typeName, $format, $handler);
}

Can anyone fix this?

Thanks for the help.
Timothée

[xabbuh]

will be fixed by #1899

[vkhramtsov]

Looks like this issue already fixed/merged by #1899. Do you have any plans for creating release?

[xabbuh]

I think currently #1961 is a blocker for the next release.

[vkhramtsov]

@xabbuh Looks like #1961 resolved now. How about release? 😉