Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate error messages #228

Closed
tgalopin opened this issue Jul 4, 2014 · 6 comments
Closed

Translate error messages #228

tgalopin opened this issue Jul 4, 2014 · 6 comments

Comments

@tgalopin
Copy link
Contributor

tgalopin commented Jul 4, 2014

Hi!

I'm working with the bundle in one of my projects and I realized the error messages were in english even if my locale is french. When I look at the bundle, it seems that there is no translation of form error messages. Did I miss it? Is there a way to enable it?

Thanks,
Titouan Galopin
@zocimek
Copy link
Contributor

zocimek commented Jul 8, 2014

The solution is already on PR in #212 or #225. I'll verify this today later

@tgalopin
Copy link
Contributor Author

tgalopin commented Jul 8, 2014

Not sure of that. The two PR are about label translation, not validation one, aren't they ?

@zocimek
Copy link
Contributor

zocimek commented Jul 8, 2014

As I said I'll verify this later

zocimek added a commit to zocimek/FOSMessageBundle that referenced this issue Jul 9, 2014
@zocimek
FriendsOfSymfony#228 added modified error messages to use proper vali…
3ca7a6a 
…dations messages (pl and en translations included)
@zocimek
Copy link
Contributor

zocimek commented Jul 9, 2014

I've verified this and It's exactly as you said. Those PR will not resolve this issue I've prepared modification for using translations also for validation messages. Unfortunately I've added only English and Polish translations. If you want just translate messages to French

@zocimek zocimek mentioned this issue Jul 9, 2014
Merged
@tgalopin
Copy link
Contributor Author

tgalopin commented Jul 9, 2014

Sure, I can translate in French, no problem. I'll create a PR when you will merge yours.

@zocimek
Copy link
Contributor

zocimek commented Jul 11, 2014

My PR has been merged. If you want you can add French translations

@tgalopin tgalopin mentioned this issue Jul 11, 2014
Merged
@zocimek zocimek closed this as completed Jul 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zocimek @tgalopin