Add mailing command #120
Merged
Add mailing command #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
reviewed
Oct 4, 2022
| @@ -239,7 +238,7 @@ private function buildCoalesce(array $fields, Context $context): string | |||
| } | |||
| } | |||
|
|
|||
| return substr($coalesce, 0, -1) . ')'; | |||
| return mb_substr($coalesce, 0, -1) . ')'; | |||
There was a problem hiding this comment.
PHPCSFIXER: .php-cs-fixer.dist.php
// Replace non multibyte-safe functions with corresponding mb function.
'mb_str_functions' => true,
There was a problem hiding this comment.
As far as I saw you used it in other classes as well, keep it similar I would say. Only diff is apperently that it will handle UTF-8 encoding better. You can disable it in the php-cs-fixer file tho, i am emotionless in that topic 😆
shyim
reviewed
Oct 4, 2022
shyim
reviewed
Oct 4, 2022
|
@shyim what is missing here? Should I revert the mb_substr and what is your / the rest's decision on the plugin config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about with @shyim in Slack here is a simple integration with email instead of webhooks.
The integration with the notifier component from symfony is nice as well, but uses the message queue to send messages. There is always the possibility of adding an own webhook interface, but probably just overkill atm (as well as adding an own mailtemplate/migration etc. to the mail integration).
Feel free to mention the other dev that you referred to.
Usage
3 configs are added
First argument must be a Saleschannel ID
bin/console frosh:monitor 4606300361c34ae3b69d813bb292f823Email can be overwritten in command:
bin/console frosh:monitor 4606300361c34ae3b69d813bb292f823 --email=michahobert@test.de
PS: Small fixes done by PHPCSFIXER