Add option to enable/disable sending of email addresses to Sentry #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does indentation change? Did your editor change it? |
|
I formatted it with Prettier :P |
|
I assume this all works fine locally? Previously I'd have said to use |
|
Works fine now that I fixed my accidental admin settings mix-up! 🙈 Option enabled
Option disabled
|
|
@davwheat care to rebase this please? :) |
|
Will do when I get to college :) |
davwheat
force-pushed
the
davwheat/dont-send-pii-setting
branch
from
34b6f2c
to
0148e35
Compare
|
Don't worry, it didn't take me 2 days to get to college ;) |
|
And there was me thinking you'd gotten lost somewhere near the student bar 🍺 |
imorland
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to the admin page to enable/disable sending of email addresses to Sentry.
Previously, by default, this extension would automatically send email addresses to Sentry as part of a user's information, along with IP, username, and user ID. While all of these are also examples of PII (personally identifiable information), the reasoning behind these being sent to Sentry is justified.
Emails can always be looked up in the Flarum database by user ID or username, so the sending of email addresses is not necessary. Nevertheless, the option is still there for people to select.
Sending of email addresses will be disabled by default.