Split the two discussion_id -> post_id migrations into 4 total #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsevillamartin
force-pushed
the
ds/split-v2-migrations-further
branch
from
3ae0ec1
to
2726554
Compare
luceos
reviewed
Jul 26, 2023
Comment on lines
64
to
67
|
|
||
| $schema->table('polls', function (Blueprint $table) { | ||
| $table->foreign('post_id')->references('id')->on('posts')->onDelete('cascade'); | ||
| }); |
There was a problem hiding this comment.
Instead of moving this to later, why not move the stuff above it to an earlier migration. This way you won't need to do that weird DB resolving and identifying whether the constraint was already created 🙈
There was a problem hiding this comment.
Makes sense. Only downside I see is the naming of these migrations, but they're still in order. Let me know how it looks now.
…n earlier one to avoid foreign key check
dsevillamartin
force-pushed
the
ds/split-v2-migrations-further
branch
from
6048bd4
to
78ff790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Split v2 migrations further to allow for easier debugging of failures & retries.
Seems to work with non prefix & prefix installations.
Confirmed
composer test).