feat: harden default group additing #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes default group in case group is deleted - stops throwing mystifying 404 when group doesnt exist
Contributor
Author
|
PHP versions 7.3 - 8.0 are no longer supported. In fact 8.0 hasn't received security patches this whole year. 8.1 already went into "Security fixes only" with 8.2 being the lowest actively supported version until the end of this year. Dropping those versions promotes users to upgrade, increasing php stability and security. It would also remove unnecessary backward compatibility issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was debugging this on our hosted platform after an admin had deleted the group assigned to the Default Group. This causes every registration to fail with a "resource not found". As this also does not have any trace, it's extremely hard to identify the underlying issue.