Skip to content

Fix up introduced regression on searchManager() call. #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ADmad merged 2 commits into from
Nov 13, 2025
Merged

Fix up introduced regression on searchManager() call. #365

ADmad merged 2 commits into from
Nov 13, 2025

Conversation

@dereuromark
Copy link
Member

@dereuromark dereuromark commented Nov 13, 2025

Resolves #364

@dereuromark dereuromark requested a review from ADmad November 13, 2025 05:39
@dereuromark dereuromark added this to the 7.x milestone Nov 13, 2025
@ADmad
Copy link
Member

ADmad commented Nov 13, 2025 •
edited
Loading

I think we should deprecate the usage of searchManager() method on the table class. It predates the addition of filter collections. Going forth users can either setup the filters from initialize() for simple use cases or create collections for a clean approach.

@ADmad
Copy link
Member

ADmad commented Nov 13, 2025

@dereuromark I have added the deprecation.

@ADmad ADmad merged commit d104764 into master Nov 13, 2025
7 checks passed
@ADmad ADmad deleted the regression-fix branch November 13, 2025 16:20
@LordSimal LordSimal mentioned this pull request Nov 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADmad ADmad Awaiting requested review from ADmad

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

7.x

Development

Successfully merging this pull request may close these issues.

searchManager method in table classes no longer called after recent change

3 participants

@dereuromark @ADmad