Comply with CakePHP Codinging Standards #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
added a commit
that referenced
this pull request
Nov 18, 2014
…s-compliance Comply with CakePHP Codinging Standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some minor deviations from the CakePHP Coding Standards that I end up fixing each time I clone the project, to get the CakePHP Code Sniffer to pass successfully. I figured they should probably just be made to the master.
One note though; the three standard php files under app/Config/Schema also cause the sniffer to throw warnings due to missing documentation blocks but this isn't special to the app-template repo, its how CakePHP ships so I wasn't certain how to handle these three files (I usually delete them shortly after cloning).
If it is desired to have a 100% pass right after cloning, I'm more than happy to add some documentation to the files and submit a new pull request.