Soft-finalize classes that might need to be changed in the future #41
Conversation
The classes changed in this commit inherit from Symfony interfaces. Changes in Symfony 8 will make it necessary to change interfaces in these classes in the near future. By soft-finalizing these classes and making them final in the next major we gain legroom to make these changes without making it an API change visible to downstream users. This is a squash-merge of FriendsOfBehat#41. Squashed commit of the following: commit f0a70e8 Author: Matthias Pigulla <mp@webfactory.de> Date: Wed Dec 17 11:29:57 2025 +0100 Add a changelog entry commit c58865c Author: Matthias Pigulla <mp@webfactory.de> Date: Wed Dec 17 10:17:14 2025 +0100 Soft-finalize classes that might need to be changed in the future
CHANGELOG.md
Outdated
| * The classes `FailureShowListener`, `SessionsListener` and `MinkExtension` have been marked as `@final`, and they will become | ||
| `final` classes in the next major release (https://github.com/FriendsOfBehat/MinkExtension/pull/41). |
There was a problem hiding this comment.
Release description is generated automatically from commits (as @stof told in another PR). Could you please move this in there?
There was a problem hiding this comment.
This was intended to be an "attention, you need to do the following" hint. I'll move it to an UPGRADING file instead, agree? Changelog was the wrong filename. Makes sense?
|
for listeners, I would also mark them as |
|
Listeners updated + UPGRADING amended. |
|
Workflow runs seems to be queued indefinitely once approved because there is no èubuntu-20.04 |
|
@stof Rebased. In case you'd merge this, could you please squash-merge? I have updated the initial comment to be a more accurate description. |
3 participants
We might need to change some classes in the near future (#37).
I think these classes were never really meant to be extension points, so let's soft-declare them as final now.
Even more, the listeners are internal and should not be used at all. Regarding the
MinkExtension, other packages might want to use it to register their own drivers.