[BC break] Remove Goutte support #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
added a commit
to mpdude/MinkExtension
that referenced
this pull request
Dec 17, 2025
Squash-merge of FriendsOfBehat#40. commit 843a686 Author: Matthias Pigulla <mp@webfactory.de> Date: Wed Dec 17 10:03:25 2025 +0100 Remove Goutte support
mpdude
added a commit
to mpdude/MinkExtension
that referenced
this pull request
Dec 17, 2025
Squash-merge of FriendsOfBehat#40. commit 843a686 Author: Matthias Pigulla <mp@webfactory.de> Date: Wed Dec 17 10:03:25 2025 +0100 Remove Goutte support
mpdude
added a commit
to mpdude/MinkExtension
that referenced
this pull request
Dec 17, 2025
Squash-merge of FriendsOfBehat#40. commit 843a686 Author: Matthias Pigulla <mp@webfactory.de> Date: Wed Dec 17 10:03:25 2025 +0100 Remove Goutte support
aik099
suggested changes
Dec 18, 2025
Comment on lines
-195
to
-224
| .. Tips : HTTPS and self-signed certificate | ||
| If you use Behat/Mink/Goutte to test your application, and want to test an | ||
| application secured with HTTPS, but with a self-signed certificate, you can use | ||
| the following parameters to avoid the validation error triggered by Guzzle: | ||
|
|
||
| * For ``Guzzle 4`` or later: | ||
|
|
||
| .. code-block:: yaml | ||
| default: | ||
| extensions: | ||
| Behat\MinkExtension: | ||
| sessions: | ||
| my_session: | ||
| goutte: | ||
| guzzle_parameters: | ||
| verify: false | ||
| * For ``Guzzle 3`` or earlier: | ||
|
|
||
| .. code-block:: yaml | ||
| default: | ||
| extensions: | ||
| Behat\MinkExtension: | ||
| sessions: | ||
| my_session: | ||
| goutte: | ||
| guzzle_parameters: | ||
| ssl.certificate_authority: false |
There was a problem hiding this comment.
Why were parts about Guzzle support removed?
Author
There was a problem hiding this comment.
I thought that was just special configuration for Goutte-with-Guzzle-X, wasn't it?
Comment on lines
-304
to
-305
| The phar version of Mink comes bundled with all 5 drivers and you don't need to do | ||
| anything except enabling them in order to use them. |
There was a problem hiding this comment.
Do we support Mink PHAR version or why have you removed this part of the docs?
Author
There was a problem hiding this comment.
I have never seen a .phar being built or provided in this repo here, so I dropped any remarks regarding a PHAR version
aik099
approved these changes
Dec 21, 2025
|
@mpdude , please also rebase to resolve any merge conflicts. |
Author
|
Will do. Let's first get #39 merged, and after that address all removals in this PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to follow up on #39 and go into a new major release.