Rss ecomm 4 16 #203
Merged
Rss ecomm 4 16 #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Friday-13
approved these changes
Jun 11, 2024
Owner
Friday-13
left a comment
Friday-13
left a comment
There was a problem hiding this comment.
Отличная работа! Я бы со своей стороны предложил подумать над файлом card-component: мне кажется, его текущее название и положение не до конца соответствуют его цели. Да, и просьба не закрывать таску на борде, т.к. там ещё подзадачи были.
Comment on lines
46
to
63
| const cardAttr1: ICardAttributes = { | ||
| inputValue: 'DISCOUNT10', | ||
| description: 'GET 30% OFF YOUR CART WITH ORDERS OVER 1000$', | ||
| }; | ||
| const card1 = new CardComponent(cardAttr1, discountContainer); | ||
| promoSection.appendChild(card1); | ||
|
|
||
| const cardAttr2: ICardAttributes = { | ||
| inputValue: 'DISCOUNT20', | ||
| description: 'TAKE AN EXTRA 20% OFF FOR ORDERS OVER 1000€', | ||
| }; | ||
| const card2 = new CardComponent(cardAttr2, discountContainer); | ||
| promoSection.appendChild(card2); | ||
|
|
||
| const cardAttr3: ICardAttributes = { | ||
| inputValue: 'DISCOUNT30', | ||
| description: 'GET 30% OFF YOUR CART WITH ORDERS OVER 1500$', | ||
| }; |
Owner
There was a problem hiding this comment.
Я думал, эту информацию будем подтягиваться из АПИ. Вёрстка отличная, можем вмёрджить. Только таску пж не закрывай, чтобы была возможность доработки)
Golosova76
approved these changes
Jun 12, 2024
…and for discount codes
Friday-13
approved these changes
Jun 12, 2024
Owner
Friday-13
left a comment
Friday-13
left a comment
There was a problem hiding this comment.
Everything good. Keep up the good work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task(s)/issue(s) 🔗
RSS-ECOMM-4_16
Description 📋
Display promo-code cards on the main page.
Make card-components for firther use on about-us page.
Done / deadline 📅
11.05.2024 / 16.05.2024
Screenshot/Illustration (optional) 📌
Comments (optional) 💬