Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bloc logs #247

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix some bloc logs #247

merged 1 commit into from
Jul 18, 2024

Conversation

Mooyeee
Copy link

@Mooyeee Mooyeee commented Jul 13, 2024

Hi, thanks a lot for this logger, really cool.
However, I noticed that with some bloc events are logged in the console with the date not formatted; it instead prints:

┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────
│ Closure: ({TimeFormat timeFormat}) => String from: opts => {
│       let timeFormat = opts && 'timeFormat' in opts ? opts.timeFormat : C[23] || CT.C23;
│       return talker_data['FieldsToDisplay|displayTitleWithTime']($this, {timeFormat: timeFormat});
│     }
│ LoginBloc created
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────

With my fix the logs are printed correctly, outputing

┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────
│ [bloc-create] | 12:41:39 387ms |
│ LoginBloc created
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────

@Frezyx
Copy link
Owner

Frezyx commented Jul 18, 2024

Hello @Mooyeee !
Thank you for this fix ❤️

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (32fe34e) to head (ff64aef).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #247      +/-   ##
===========================================
+ Coverage   98.80%   100.00%   +1.19%     
===========================================
  Files          28         3      -25     
  Lines         584        98     -486     
===========================================
- Hits          577        98     -479     
+ Misses          7         0       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Frezyx Frezyx merged commit 5cbf23b into Frezyx:master Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants