Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with display time inside riverpod package #246

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

yelmuratoff
Copy link
Contributor

Thanks a lot for contributing!

Fix issue with display time inside riverpod package

From this:
Screenshot 2024-06-28 at 03 06 14

To this:
Screenshot 2024-06-28 at 03 07 04

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fd6ce2) to head (244b43a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #246      +/-   ##
===========================================
+ Coverage   98.80%   100.00%   +1.19%     
===========================================
  Files          28         6      -22     
  Lines         584       198     -386     
===========================================
- Hits          577       198     -379     
+ Misses          7         0       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Frezyx Frezyx linked an issue Jun 28, 2024 that may be closed by this pull request
7 tasks
Copy link
Owner

@Frezyx Frezyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yelmuratoff 👋
Thanks for this fast fix ❤️

I forgot to update the riverpod logger 🥶

@Frezyx Frezyx merged commit 83bb8db into Frezyx:master Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new TimeFormat in ecosystem packages
3 participants