Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talker Riverpod update: print full data for talker page #239

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

yelmuratoff
Copy link
Contributor

Right now Riverpod Talker only displays full information for the console, but there is literally no information in the Talker Page itself. Not about the stats, not about the errors, stack trace.
I've changed the code to add more information, also added a new field for errors printFailFullData.

@Frezyx
Copy link
Owner

Frezyx commented May 27, 2024

Hello @yelmuratoff 🤝
Thank you for your PR! Could you please fix the formatting issues before we merge this?

@Frezyx Frezyx added the enhancement New feature or request label May 27, 2024
@Frezyx Frezyx added the awaiting On the list for consideration or merge label May 27, 2024
@yelmuratoff
Copy link
Contributor Author

@Frezyx is everything okay now?)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9537000) to head (b50a32b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #239      +/-   ##
===========================================
+ Coverage   99.82%   100.00%   +0.17%     
===========================================
  Files          28         3      -25     
  Lines         565        99     -466     
===========================================
- Hits          564        99     -465     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Frezyx
Copy link
Owner

Frezyx commented May 27, 2024

@Frezyx is everything okay now?)

Yes 💯

@Frezyx Frezyx merged commit 0a37743 into Frezyx:master Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting On the list for consideration or merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants