Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: refactor and enhance UI #131

Merged
merged 6 commits into from
Jul 27, 2023
Merged

style: refactor and enhance UI #131

merged 6 commits into from
Jul 27, 2023

Conversation

jnelle
Copy link
Contributor

@jnelle jnelle commented Jul 26, 2023

Changelog

  • Rename the bacgroundColor parameter to backgroundColor
  • Add the buttonDismissText Widget
  • Add the dismissButton Widget
  • Add the titleTextStyle TextStyle
  • Add the messageTextStyle TextStyle
  • Rename the color property in the Container decoration
  • Add an onPressed callback to the TextButton widget
  • use paddingOf instead size this method will cause the given [context] to rebuild any time that the [MediaQueryData.padding] property of the ancestor [MediaQuery] changes. Checkout the following PR for more informations about MediaQuery as InheritedModel

- Modify the `bacgroundColor` parameter to `backgroundColor`
- Add the `buttonDismissText` parameter
- Add the `dismissButton` parameter
- Add the `titleTextStyle` parameter
- Add the `messageTextStyle` parameter
- Modify the `color` property in the `Container` decoration
- Modify the `style` property in the `Text` widget for `title`
- Modify the `style` property in the `Text` widget for `message`
- Add an `onPressed` callback to the `TextButton` widget
- Modify the `child` property in the `TextButton` widget
* this method will cause the given [context] to rebuild any time that the [MediaQueryData.padding] property of the ancestor [MediaQuery] changes

Signed-off-by: jnelle <602579@fom-net.de>
Signed-off-by: jnelle <602579@fom-net.de>
- Remove import of `snackbar.dart`
* also lint workflow file

Signed-off-by: jnelle <602579@fom-net.de>
@jnelle
Copy link
Contributor Author

jnelle commented Jul 26, 2023

Should work now, please trigger the workflow again

@jnelle
Copy link
Contributor Author

jnelle commented Jul 26, 2023

Is there something missing for merging?

Signed-off-by: jnelle <602579@fom-net.de>
Copy link
Owner

@Frezyx Frezyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @jnelle 🚀
Thanks a lot!

@Frezyx Frezyx merged commit 7a5af7d into Frezyx:master Jul 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants