Merge pull request #127 from matt400m/master

Fix http-response logs.
Frezyx · Jul 10, 2023 · 49017bc · 49017bc
2 parents 2537a3f + 50a4a36
commit 49017bc
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/talker_dio_logger/lib/dio_logs.dart b/packages/talker_dio_logger/lib/dio_logs.dart
@@ -67,7 +67,7 @@ class DioResponseLog extends TalkerLog {
 
     final responseMessage = response.statusMessage;
     final data = response.data;
-    final headers = response.requestOptions.headers;
+    final headers = response.headers.map;
 
     msg += '\nStatus: ${response.statusCode}';
 

diff --git a/packages/talker_dio_logger/test/logger_test.dart b/packages/talker_dio_logger/test/logger_test.dart
@@ -32,5 +32,22 @@ void main() {
       logger.onResponse(response, ResponseInterceptorHandler());
       expect(talker.history.last.message, logMessage);
     });
+
+    test('onResponse method should log http response headers', () {
+      logger = TalkerDioLogger(talker: talker, settings: TalkerDioLoggerSettings(
+        printResponseHeaders: true
+      ));
+      final options = RequestOptions(path: '/test');
+      final response = Response(requestOptions: options, statusCode: 200, headers: Headers()..add("HEADER",
+      "VALUE"));
+      logger.onResponse(response, ResponseInterceptorHandler());
+      expect(talker.history.last.generateTextMessage(), '[http-response] [GET] /test\n'
+          'Status: 200\n'
+          'Headers: {\n'
+          '  "header": [\n'
+          '    "VALUE"\n'
+          '  ]\n'
+          '}');
+    });
   });
 }