Format on save issue

[FrenchTechLead]

Current behaviour :

The .jvs code is getting formatted on save regardless of the value of robusta.formatOnSave property.

Expected behaviour:

• The .jvs code should not get formatted if the property robusta.formatOnSave is set to false.
• If robusta.formatOnSave is set to true and robusta.compileOnSave is also set to true : make sure to let finish the formatting task before running the compiling task.

[manekinekko]

I am working on this!

[FrenchTechLead]

You rock man !

[manekinekko]

After investigating this, it seems that your code is working as expected.

I tried your extension locally, and I can format (or not) the .jvs file based on the value of robusta.formatOnSave. Same thing for compiling.

Did I miss something?

[FrenchTechLead]

After investigating this, it seems that your code is working as expected.

I tried your extension locally, and I can format (or not) the .jvs file based on the value of robusta.formatOnSave. Same thing for compiling.

Did I miss something?

I think the problem occurs when the property editor.formatOnSave is set to true, in this case the RobustaFormatingProvider is called even if robusta.formatOnSave is set to false. because RobustaFormatingProvider is registered as a formatting provider to vscode.

[manekinekko]

Oh! Gotcha! I can reproduce the issue when setting editor.formatOnSave to true. I will investigate this issue.

[manekinekko]

I did some researches and it seems that the best options is to remove the robusta.formatOnSave option and use editor.formatOnSave like so:

// Set the default
"editor.formatOnSave": false,

// Enable per-language
"[jvs]": {
    "editor.formatOnSave": true
}

Also, your current implementation of the formatter is the correct approach, according to the documentation.

[FrenchTechLead]

I did some researches and it seems that the best options is to remove the robusta.formatOnSave option and use editor.formatOnSave like so:

// Set the default
"editor.formatOnSave": false,

// Enable per-language
"[jvs]": {
    "editor.formatOnSave": true
}

Also, your current implementation of the formatter is the correct approach, according to the documentation.

You're right, that seems to be the issue here, I think we should move the robusta.formatOnSave and the corresponding action as well, to let the formatting provider do the the job by it self.