-
-
Notifications
You must be signed in to change notification settings - Fork 672
fix health indicators across browser #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix health indicators across browser #2827
Conversation
|
@dharapandya85 is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@dharapandya85 Haven't tried this in Brave yet, but it displays really bad in other browsers (like Firefox). |
|
@DreadKnight , I removed I created a constant centerX with here, we use hardcoded pixel values, which can vary in different browsers, so, I thought to replace this |
|
@dharapandya85 Why is this marked "ready for review" with no new patches that might fix? 🐻 I see; I would have tried a totally different approach, like browser specific CSS tweak for Brave. This is a rather small issue that might just go away on its own, so don't spend too much on it. |
…ical offset with unified coordinates for pill and text
|
Please check now. I could not see feedback earlier, so I marked it for review, apologies. |
|
@dharapandya85 Way better, text just a tad above in Firefox etc. as you can see: Also, comments lack style consistency with the rest of the code base 🐻 |
|
@dharapandya85 Almost there. Still 1-2 pixels too high and having inconsistent comments, should be like "// This". |
|
Please check now. |
|
@dharapandya85 There's a space between // and first non-code commented capitalized letter 🐻 |
|
I forgot there is a space between // and comment, so I formatted the comments. |


Description:
This PR fixes misalignment of hanging creature health indicators, this appears in certain browser (Brave).
Changes:
This fixes issue #2088
My wallet address is 0x1834Ad801952DcB73E88700c889C180d13eF919F