Skip to content

Conversation

@Matt-Foo-SL
Copy link
Contributor

@Matt-Foo-SL Matt-Foo-SL commented Sep 28, 2025

This is a followup fix for branch #2684 by @emna9

  • Fixed the logic, that was an issue on the branch. You can now escort targets by 1 hex from both player 1 and player 2.

However I have found more underlying issues namely

  • some leftover graphics of the target after hovering mouse on and then off a target location. Is this fine? @DreadKnight (see screenshot below)
Screenshot 2025-09-28 182742 - If I escort a target and then move it the next turn, there will be some leftover graphics also. (see screenshot below) Screenshot 2025-09-28 182558 maybe @emna9 can help with the 2 above issues? I am not sure how to clean up the previewCreature function call.

Also in this branch and in production, I have noticed 2 potential issues

  1. scavenger is not able to escort the target if it is infront of it.
  2. If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)
    Are both of this intentional? @DreadKnight
Screenshot 2025-09-28 200701 This fixes issue #2684. Don't merge this PR yet. I have not pull the latest changes from master branch, so this is just for review

@vercel
Copy link

vercel bot commented Sep 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
ancientbeast Ready Ready Preview Sep 28, 2025 0:13am

@DreadKnight
Copy link
Member

@Matt-Foo-SL Heya! The leftover graphics issue is a known one and should already be fixed in master (see closed issues or PRs).
You can test master to see if they still happen over there as well.

Regarding the game mechanic, Scavenger can only pull units, meaning they need to be behind (it will grab them using its tail), unable to push units (there are other ones that do just that).

@DreadKnight DreadKnight marked this pull request as draft October 2, 2025 05:54
@Matt-Foo-SL
Copy link
Contributor Author

2. If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)

Ah I see, okay. What about this point: If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)?

@DreadKnight
Copy link
Member

2. If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)

Ah I see, okay. What about this point: If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)?

As Busta Rhymes sang: "There's no going back now!". Scavenger can only pull using the tail while flying. You have to think of unit animations and what's possible irl 🐻

If you want to move unit back, you'll have to fly over it first. Eventually there might be an undo move button, there's an open issue for that. This will rewind things animation wise at some point.

@Matt-Foo-SL
Copy link
Contributor Author

  1. If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)

Ah I see, okay. What about this point: If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)?

As Busta Rhymes sang: "There's no going back now!". Scavenger can only pull using the tail while flying. You have to think of unit animations and what's possible irl 🐻

If you want to move unit back, you'll have to fly over it first. Eventually there might be an undo move button, there's an open issue for that. This will rewind things animation wise at some point.

Gotcha. Another thing is an update to the ability description is probably needed as well? Currently it says "Carries over a frontal or..." Maybe just remove the frontal part?

@DreadKnight
Copy link
Member

  1. If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)

Ah I see, okay. What about this point: If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)?

As Busta Rhymes sang: "There's no going back now!". Scavenger can only pull using the tail while flying. You have to think of unit animations and what's possible irl 🐻

If you want to move unit back, you'll have to fly over it first. Eventually there might be an undo move button, there's an open issue for that. This will rewind things animation wise at some point.

Gotcha. Another thing is an update to the ability description is probably needed as well? Currently it says "Carries over a frontal or..." Maybe just remove the frontal part?

That stuff means that the ability works inline. If Scavenger has a frontal unit, Scavenger will turn around and be able to carry it in that direction. Hence ability description is accurate and no need for an update.

@Matt-Foo-SL
Copy link
Contributor Author

  1. If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)

Ah I see, okay. What about this point: If the target is behind scavenger and it has flew some distance forward, it is unable to escort backwards. (see screenshot below)?

As Busta Rhymes sang: "There's no going back now!". Scavenger can only pull using the tail while flying. You have to think of unit animations and what's possible irl 🐻
If you want to move unit back, you'll have to fly over it first. Eventually there might be an undo move button, there's an open issue for that. This will rewind things animation wise at some point.

Gotcha. Another thing is an update to the ability description is probably needed as well? Currently it says "Carries over a frontal or..." Maybe just remove the frontal part?

That stuff means that the ability works inline. If Scavenger has a frontal unit, Scavenger will turn around and be able to carry it in that direction. Hence ability description is accurate and no need for an update.

I see. I will make some adjustments to the code and make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants