Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve #42: Render historic=ruins #63

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Conversation

petervojtek
Copy link
Member

@petervojtek petervojtek commented Feb 10, 2019

vzdy sa rendruje ikonka.
ak je text, rendruje sa aj ten.
ak je to way, rendruje sa aj pod ikonou a textom aj budova (trosku svetlejsie ako building).

akurat ikonku som z nudze zatial prevzal z castle, lebo mam problem editovat svg na macos-e. jediny volne dostupny nastroj ktory za nieco stoji je inkscape, lenze ten na macos-e funguje velmi biedne. a ostatne volne dostupne nastroje su velmi slabe.

a treba si pregenerovat data, lebo som musel zmenil mapping.yml

screenshot 2019-02-10 at 11 20 27

@petervojtek petervojtek requested a review from zdila February 10, 2019 10:25
@kaylesk
Copy link
Member

kaylesk commented Feb 10, 2019

@petervojtek
Copy link
Member Author

ano, ta je super, po presne takej tuzim :)

ja som hladal v tomto repozitari a nenasiel som ju, preto som improvizoval.
https://github.com/gravitystorm/openstreetmap-carto/tree/master/symbols

@zdila
Copy link
Member

zdila commented Feb 10, 2019

Chyba mi zaznam v additional.sql - ako velmi nizka priorita, kedze historic=ruins vravi "nieco historicke a rozpadnute", kludne napr. stara chata. Na tagovanie tychto veci su casto vhodnejsie ine tagy.

@petervojtek
Copy link
Member Author

Martin @zdila , upravil som additional.sql a zmenil ikonku.

screenshot 2019-02-12 at 08 03 26

('gate');
('game_feeding'),
('gate'),
('ruins');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trosku to dodatocne upravim, lebo brana by mohla mat kludne nizsiu prio ako zrucanina :-)

@zdila zdila merged commit 1482b5e into master Feb 12, 2019
@zdila zdila deleted the feature/#42-render-historic-ruins branch November 13, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants