Workaround for https://github.com/electron/electron/issues/49253

[Devenor]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Workaround for #8359

Description

Workaround for Electron issue electron/electron#49253, causing Freetube to crash when showing a window minimized in the tray on Linux + Wayland.

Screenshots

Testing

1. Minimize application
2. Go to tray
3. Click on Show to show the minimized window
4. The window shows

Desktop

• OS: Ubuntu
• OS Version: 22.04.3 LTS
• FreeTube version: 0.23.13-beta

Additional context

[absidue]

Could you please invert the check and flip the if-else branches as it is a bit more readable that way.

[Devenor]

Sure, but I'm suddenly having some weird problems with the linter and I can't find the cause, maybe you know what it's about? It says:

[12:56:12] devenor@localhost:~/FreeTube$ yarn lint
yarn run v1.22.22
$ run-p eslint-lint lint-style
$ stylelint "src/**/*.{css,scss}"
$ eslint --config eslint.config.mjs "src/**/*.js" "src/renderer/**/*.vue" "static/*.js" "_scripts/*.js" "_scripts/**/*.mjs"
Error [ERR_REQUIRE_CYCLE_MODULE]: Cannot require() ES Module /home/devenor/FreeTube/stylelint.config.mjs in a cycle. (from /home/devenor/FreeTube/node_modules/cosmiconfig/dist/loaders.js)

[absidue]

Please make sure you are using Node.js 24+.

[Devenor]

Thanks, that did the trick, the PR is updated.

[efb4f5ff-1298-471a-8973-3d47447115dc]

@Devenor idk if you can do something about it but it looks very glitchy

VirtualBoxVM_yhY87kgjlE.mp4

[Devenor]

I don't think it can be fixed... all I'm doing is calling maximize, and it also happens using show.

It's very smooth on my Ubuntu though (no VM). Maybe yours is worse because of the VM and running it in dev mode ? Could you try building it and running the build instead ?

[absidue]

@efb4f5ff-1298-471a-8973-3d47447115dc I suspect you don't have hardware acceleration/3D acceleration enabled for your VM and have animations enabled in Ubuntu (even the menu in the top right looks dodgy in your video).

[efb4f5ff-1298-471a-8973-3d47447115dc]

@efb4f5ff-1298-471a-8973-3d47447115dc I suspect you don't have hardware acceleration/3D acceleration enabled for your VM and have animations enabled in Ubuntu (even the menu in the top right looks dodgy in your video).

I suspect you don't have hardware acceleration/3D acceleration enabled

This was turned on in the clip

and have animations enabled in Ubuntu (even the menu in the top right looks dodgy in your video).

This was turned off in the clip

Could you try building it and running the build instead ?

Will try

[Devenor]

@efb4f5ff-1298-471a-8973-3d47447115dc I see you have the green turtle in the lower right side of your screen, that's most certainly the issue. You should try disabling Hyper-V, in my case I can do that by typing this in a command prompt as admin, and then restarting: bcdedit /set hypervisorlaunchtype off

It may not work just by doing that, though, and other steps could be necessary.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I think its safe to say that these issues are unrelated to your PR. LGTM. Thanks @Devenor !