Skip to content

Fix sigFrameScript on dev in windows#8134

Merged
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
PikachuEXE:fix/dev-windows
Oct 15, 2025
Merged

Fix sigFrameScript on dev in windows#8134
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
PikachuEXE:fix/dev-windows

Conversation

@PikachuEXE

@PikachuEXE PikachuEXE commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Fix from #8127

Description

The error that occurs on windows for https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.23.10-beta also occurs when running dev (dev branch not master branch) (also nightly builds are using terser minified code so it's fine)
This PR should fix the issue (and should not affect any builds)

Screenshots

Testing

Run dev on windows and ensure no CSP error (video can be played)

Optionally download from the following build to ensure this PR does not affect non-dev
https://github.com/PikachuEXE/FreeTube/actions/runs/18514459270

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version:

Additional context

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 15, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 15, 2025 01:07
absidue
absidue requested changes Oct 15, 2025
View reviewed changes

@absidue absidue left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dodgy custom minify was only needed for the master branch because the terser version was too old and didn't have the minify_sync function, please delete these changes and instead remove the is dev check for minify_sync and always run it.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 15, 2025
@PikachuEXE

PikachuEXE commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

Updated and tested in windows dev

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Oct 15, 2025
@FreeTubeBot FreeTubeBot merged commit 95ec469 into FreeTubeApp:development Oct 15, 2025
5 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 15, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 16, 2025
@PikachuEXE
Merge branch 'development' into sabr-pr
f476697 
* development:
  Bump package version from 0.23.11 to 0.23.12 (FreeTubeApp#8138)
  Add error handling to the deciphering code (FreeTubeApp#8139)
  Fix video playback by using video ID bound poToken (FreeTubeApp#8137)
  Hide subscriptions wrapper on mobile and center bottom SideNav items (FreeTubeApp#8133)
  ! Fix sigFrameScript on dev in windows (FreeTubeApp#8134)
  Translated using Weblate (Estonian)
  Bump github/codeql-action from 3 to 4 (FreeTubeApp#8124)
  Translated using Weblate (Welsh)
  Bump mikefarah/yq from 4.47.2 to 4.48.1 (FreeTubeApp#8123)
  Bump stefanzweifel/git-auto-commit-action from 6 to 7 (FreeTubeApp#8125)
  Bump package version from 0.23.10 to 0.23.11 (FreeTubeApp#8126)

# Conflicts:
#	src/renderer/helpers/api/local.js
PikachuEXE added a commit to NishPatel101/FreeTube that referenced this pull request Oct 21, 2025
@PikachuEXE
Merge branch 'development' into feat/clickable-playlist-progressbar
d713a9f 
* development: (88 commits)
  Bump the eslint group with 4 updates (FreeTubeApp#8158)
  Translated using Weblate (German)
  Bump shaka-player from 4.16.4 to 4.16.6 (FreeTubeApp#8167)
  Bump marked from 16.4.0 to 16.4.1 (FreeTubeApp#8159)
  Bump electron from 38.2.2 to 38.3.0 (FreeTubeApp#8161)
  Bump actions/setup-node from 5 to 6 (FreeTubeApp#8162)
  Bump youtubei.js from 16.0.0 to 16.0.1 (FreeTubeApp#8163)
  Translated using Weblate (Persian)
  Translated using Weblate (Czech)
  Translated using Weblate (Bulgarian)
  Add missing IS_ELECTRON and SUPPORTS_LOCAL_API checks (FreeTubeApp#8147)
  Simplify the NATIVE_THEME_UPDATE event handler (FreeTubeApp#8140)
  Bump package version from 0.23.11 to 0.23.12 (FreeTubeApp#8138)
  Add error handling to the deciphering code (FreeTubeApp#8139)
  Fix video playback by using video ID bound poToken (FreeTubeApp#8137)
  Hide subscriptions wrapper on mobile and center bottom SideNav items (FreeTubeApp#8133)
  ! Fix sigFrameScript on dev in windows (FreeTubeApp#8134)
  Translated using Weblate (Estonian)
  Bump github/codeql-action from 3 to 4 (FreeTubeApp#8124)
  Translated using Weblate (Welsh)
  ...
@PikachuEXE PikachuEXE deleted the fix/dev-windows branch November 10, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot