Add Hide channels based on text#7948
Conversation
github-actions
Bot
added
the
PR: waiting for review
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Please address all the lint warnings
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Head branch was pushed to by a user without write access
| Hide Channels: Enter a channel ID to hide all videos, playlists and the channel itself from appearing in search, trending, most popular and recommended. | ||
| The channel ID entered must be a complete match and is case sensitive. | ||
| Hide Subscriptions Live: 'This setting is overridden by the app-wide "{appWideSetting}" setting, in the "{subsection}" section of the "{settingsSection}"' | ||
| Hide Channels Containing Text: 'Hides channels & all matching videos from channels whose name contains the above text' |
There was a problem hiding this comment.
Adds a toggle button to hide all channels, playlists and videos from channels that are matching/contain any strings from the existing tags of "Hide videos and playlists containing text"
Your PR description is very clear but when i read this its very confusing. Also dont use &
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
im not sure if a toggle is the right way to go here. It looks very out of place and enabling it doesnt make it clear to me what it does
Head branch was pushed to by a user without write access
|
@ozrendev could you update the PR body to reflect the latest changes |
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Channel is hidden everywhere expect community tab
VirtualBoxVM_OtUE0jiHZp.mp4
Head branch was pushed to by a user without write access
|
Video gets removed but the post is still there. I meant to not show the post at all |
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
Bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Looks like Weblate will cause merge conflicts every time a translation is pushed and will keep doing so. What's the best way to coordinate this? Would it be possible to get this fully approved (if it all looks good) and then resolve the conflicts? |
|
it will dismiss approvals after conflicts are resolved so we could coordinate approving it right after conflicts have been resolved @absidue @PikachuEXE please check if changes made are ok so we could maybe coordinate a time to resolve conflicts and approve at the same time. We could also lock weblate for a day? |
|
Just lock weblate for a day after conflict resolved |
|
Should I resolve the conflicts now or wait for weblate to be locked? Also may be easier to coordinate time-wise if someone else resolves the conflicts if it's not an issue |
|
@ozrendev i can lock weblate now Edit: its locked |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Thanks! Conflicts have been resolved now |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
|
Weblate is unlocked again. |
5 participants
Pull Request Type
Related issue
closes #7426
Description
Updates the "Hide videos and playlists containing text" filter to also include/hide channels.
Testing
Check that the filter is working for: