Refactor/cleanup tray related code after PR merged#7856
Conversation
The webpack config for the main file sets the value of Those are just the steps I take when I want to look at the output, but if you find some better ways to do it, I am all ears :). |
|
Updated testing section and locally tested (from previous macOS only testing |
* development: (84 commits) Translated using Weblate (Chinese (Traditional Han script)) Show more information on long playlists. (FreeTubeApp#7804) Translated using Weblate (French) Refactor/cleanup tray related code after PR merged (FreeTubeApp#7856) Translated using Weblate (Estonian) Translated using Weblate (Italian) Translated using Weblate (Afrikaans) Translated using Weblate (Latvian) Translated using Weblate (Lithuanian) Translated using Weblate (Norwegian Nynorsk) Translated using Weblate (Galician) Translated using Weblate (Korean) Translated using Weblate (Slovenian) Translated using Weblate (Danish) Translated using Weblate (Kurdish) Translated using Weblate (Catalan) Translated using Weblate (Indonesian) Translated using Weblate (Greek) Translated using Weblate (Slovak) Translated using Weblate (Spanish (Mexico)) ...
* development: (25 commits) Translated using Weblate (Chinese (Traditional Han script)) Show more information on long playlists. (FreeTubeApp#7804) Translated using Weblate (French) Refactor/cleanup tray related code after PR merged (FreeTubeApp#7856) Translated using Weblate (Estonian) Translated using Weblate (Italian) Translated using Weblate (Afrikaans) Translated using Weblate (Latvian) Translated using Weblate (Lithuanian) Translated using Weblate (Norwegian Nynorsk) Translated using Weblate (Galician) Translated using Weblate (Korean) Translated using Weblate (Slovenian) Translated using Weblate (Danish) Translated using Weblate (Kurdish) Translated using Weblate (Catalan) Translated using Weblate (Indonesian) Translated using Weblate (Greek) Translated using Weblate (Slovak) Translated using Weblate (Spanish (Mexico)) ...
* $ Refactor/cleanup tray related code after PR merged * $ Guard tray related code behind process.platform check
Pull Request Type
Related issue
#6915
Description
Cleanup per #6915 (review)
Addressed stuff:
.lengthas boolean ->.length === 0 / > 0process.platform !== 'darwin'so they should be removed on build timeScreenshots
Nope
Testing
Same as #6915
_scripts/webpack.main.config.jsfrom'process.platform':'${process.platform}',to'process.platform': '\'darwin\'',(replace `darwin with other values lateryarn run pack && npx prettier@2.8.8 --write --no-config dist/main.jsdist/main.jssetIgnoreDoubleClickEventsabsent withdarwin, present with other valuesDesktop
Additional context