Skip to content

Fix cannot use alt + D on macOS#7448

Merged
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
PikachuEXE:fix/mac-searchbar-focus
May 24, 2025
Merged

Fix cannot use alt + D on macOS#7448
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
PikachuEXE:fix/mac-searchbar-focus

Conversation

@PikachuEXE

@PikachuEXE PikachuEXE commented May 24, 2025

Copy link
Copy Markdown
Member

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#2822 (comment)

Description

https://altcodesguru.com/mac-alt-key-codes.html
Option + D = but the code before PR only scan for 'd/D` so it never works on macOS

Screenshots

Testing

  • Open window on macOS
  • Option + D
  • Ensure top nav bar focus

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot merged commit 5a38edd into FreeTubeApp:development May 24, 2025
5 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 24, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request May 28, 2025
* development: (29 commits)
  Convert the electron-builder scripts to ESM (FreeTubeApp#7471)
  Bump shaka-player from 4.14.12 to 4.14.14 (FreeTubeApp#7463)
  Bump electron from 36.2.1 to 36.3.1 (FreeTubeApp#7466)
  Bump marked from 15.0.11 to 15.0.12 (FreeTubeApp#7467)
  Bump globals from 16.1.0 to 16.2.0 (FreeTubeApp#7461)
  Bump swiper from 11.2.6 to 11.2.8 (FreeTubeApp#7462)
  Bump webpack from 5.99.8 to 5.99.9 (FreeTubeApp#7464)
  Bump npm-run-all2 from 8.0.2 to 8.0.4 (FreeTubeApp#7465)
  Bump electron-context-menu from 4.0.5 to 4.1.0 (FreeTubeApp#7468)
  Translated using Weblate (Afrikaans)
  Migrate FtCreatePlaylistPrompt to the composition API (FreeTubeApp#7439)
  ! Fix cannot use alt + D on macOS (FreeTubeApp#7448)
  Use better v-for keys in various places (FreeTubeApp#7447)
  Fix channel about tab (FreeTubeApp#7446)
  Translated using Weblate (Tamil)
  Translated using Weblate (Urdu)
  Translated using Weblate (Georgian)
  Translated using Weblate (Khmer (Central))
  Translated using Weblate (Korean)
  Translated using Weblate (Hebrew)
  ...

# Conflicts:
#	package.json
#	yarn.lock
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request May 28, 2025
* development: (27 commits)
  Migrate FtCreatePlaylistPrompt to the composition API (FreeTubeApp#7439)
  ! Fix cannot use alt + D on macOS (FreeTubeApp#7448)
  Use better v-for keys in various places (FreeTubeApp#7447)
  Fix channel about tab (FreeTubeApp#7446)
  Translated using Weblate (Tamil)
  Translated using Weblate (Urdu)
  Translated using Weblate (Georgian)
  Translated using Weblate (Khmer (Central))
  Translated using Weblate (Korean)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Polish)
  Translated using Weblate (Afrikaans)
  Translated using Weblate (Basque)
  Translated using Weblate (Bengali)
  Translated using Weblate (Estonian)
  Translated using Weblate (Kurdish)
  Translated using Weblate (Arabic)
  Migrate FtAutoLoadNextPageWrapper to the composition API (FreeTubeApp#7438)
  Translated using Weblate (Vietnamese)
  Bump the eslint group with 4 updates (FreeTubeApp#7427)
  ...

# Conflicts:
#	package.json
#	yarn.lock
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request May 28, 2025
* custom-builds/current: (39 commits)
  * Implement context menu item "search X in new window"
  Convert the electron-builder scripts to ESM (FreeTubeApp#7471)
  Bump shaka-player from 4.14.12 to 4.14.14 (FreeTubeApp#7463)
  Bump electron from 36.2.1 to 36.3.1 (FreeTubeApp#7466)
  Bump marked from 15.0.11 to 15.0.12 (FreeTubeApp#7467)
  Bump globals from 16.1.0 to 16.2.0 (FreeTubeApp#7461)
  Bump swiper from 11.2.6 to 11.2.8 (FreeTubeApp#7462)
  Bump webpack from 5.99.8 to 5.99.9 (FreeTubeApp#7464)
  Bump npm-run-all2 from 8.0.2 to 8.0.4 (FreeTubeApp#7465)
  Bump electron-context-menu from 4.0.5 to 4.1.0 (FreeTubeApp#7468)
  Translated using Weblate (Afrikaans)
  Migrate FtCreatePlaylistPrompt to the composition API (FreeTubeApp#7439)
  ! Fix cannot use alt + D on macOS (FreeTubeApp#7448)
  Use better v-for keys in various places (FreeTubeApp#7447)
  Fix channel about tab (FreeTubeApp#7446)
  Translated using Weblate (Tamil)
  Translated using Weblate (Urdu)
  Translated using Weblate (Georgian)
  Translated using Weblate (Khmer (Central))
  Translated using Weblate (Korean)
  ...

# Conflicts:
#	package.json
@PikachuEXE PikachuEXE deleted the fix/mac-searchbar-focus branch June 2, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants