-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playlist duration to playlist view #7007
base: development
Are you sure you want to change the base?
Add playlist duration to playlist view #7007
Conversation
Co-authored-by: Sulliva LUONG <sullivanluong@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to replicate, but it seems there is a video in that playlist with a non-number for |
Errors are gone but when a short is added to a playlist the it wont show total time anymore. To me it seems like a harsh penalty for having shorts without timestamps within the playlist. I totally accept if these are the limitations we cant circumvent though VirtualBoxVM_PtnY6raIhA.mp4 |
That was the behavior I intended, but it can be changed. My logic is that, if there are any number of videos with no duration in a playlist, the total duration will be wrong. |
Sounds logical. One thing i came up with is to call it approximately total time so we can still show it but maybe that is just bad UX |
@PikachuEXE |
Don't show it seems better UX for now |
Add playlist duration to playlist view
Pull Request Type
Related issue
This is based on this PR: #6657
closes #6152
Description
This PR adds the total playlist duration to the
playlist-info
component which is displayed within thePlaylist
view.Screenshots
Testing
(This can be accomplished by adding only videos from RSS feed subscriptions to a user playlist.)
Desktop