-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to update the region/geolocation files #3701
Add a script to update the region/geolocation files #3701
Conversation
What do you mean by "Test trending with various locations" ?_? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added language sensitive sorting, the only language that changed was |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Removed the extra sentence and added sorting for the languages, any that looks incorrectly sorted now, is correct unless the standard javascript Intl.Collator API is broken, which i highly doubt. |
Add a script to update the region/geolocation files
Pull Request Type
Related issue
close #3441
Description
Currently FreeTube lists a bunch geolocations for trending that YouTube doesn't support and is also missing some that YouTube does support, this is because the locations were taken from a repository that had location information translated into various different languages.
This pull request adds a script that extracts the geolocations from YouTube in as many of the active languages in FreeTube as possible, that way we have an accurate list and also have them translated into various different languages.
For some languages I've added manual mappings, like French which is
fr-FR
in FreeTube butfr
on YouTube.The script currently only collects geolocation translations for whitelisted/active languages in FreeTube, it doesn't for any of the other languages.
Here is the script output:
Screenshots
Testing
Test trending with various locations, none of them should error like they did before.