Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to a more appropriate country name #2895

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

gnuhead-chieb
Copy link
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Description

Updated country name 中国台湾省(Taiwan, Province of China) to just simply 台湾(Taiwan) in Japanese and Chinese.
Taiwan has a completely independent administration from the PRC and is not a province of it.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 26, 2022 19:50
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 26, 2022
@PikachuEXE
Copy link
Collaborator

@gnuhead-chieb
Copy link
Contributor Author

Please use https://github.com/FreeTubeApp/FreeTube#localization

Country names aren't there in weblate.

@ChunkyProgrammer
Copy link
Member

@PikachuEXE see #720

Most regions come from another project but Hong Kong and Taiwan were added in different PRs

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case let's update

@FreeTubeBot FreeTubeBot merged commit a495ff3 into FreeTubeApp:development Nov 28, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants