-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
Description
Guidelines
- I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
- I have searched the documentation for information that matches the description of the feature request I want to file, without success.
- This issue contains only one feature request.
Problem Description
The addition of new themes can introduce many different types of accessibility issues with regards to the color contrast. This can be time-intensive for contributors to manually test and identify.
Proposed Solution
Implement automated digital accessibility testing for themes. This means:
- For base themes with related primary & secondary theme colors (e.g., Dracula & Dracula Cyan), require that there is a 3+:1 color contrast between them.
- Ensure that each base theme's text colors have a 4.5+:1 (WCAG AA) or 7+:1 (WCAG AAA) color contrast with both the
card-bg-color
,bg-color
, andsecondary-card-bg-color
. - Require that each primary & secondary theme's text-with color has a 4.5+:1 (WCAG AA) or 7+:1 (WCAG AAA) color contrast with them.
- (arguable / post-MVP because it is not followed by many of our themes currently) Require that there is a 3+:1 color contrast with each base theme's
search-bar-color
andsecondary-card-bg-color
against thecard-bg-color
.
Automated enforcement of this as a part of our build process can be done as part of the same effort or split into a separate PR if deemed appropriate.
Alternatives Considered
Don't implement this feature.
Issue Labels
new feature
Additional Information
I suggest that this be done before merging any future theme PRs. Otherwise, any new theme PRs need to have exhaustive link & screenshot evidence of manual accessibility testing for all relevant color combinations before being considered ready to review.
artkapl
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
To assign