Simplify file encoding #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaldhoer
force-pushed
the
ascii-encoding
branch
2 times, most recently
from
9852e2a to
67088d0
Compare
aggarg
approved these changes
Jun 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 4 4
Lines 1272 1272
Branches 342 342
=======================================
Hits 1172 1172
Misses 53 53
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
n9wxu
approved these changes
Jun 30, 2021
laroche
pushed a commit
to laroche/FreeRTOS-Kernel
that referenced
this pull request
Apr 18, 2024
* Add a daemon socket listener so that the process loop will only execute if data is available on the socket. * Set process loop timeout to 0 so that other commands do not have to wait for a process loop that isn't doing anything. * Add an additional publisher task to show multiple tasks publishing simultaneously. * Clarify what is meant by "synchronous" and "asynchronous" publishes. * Fix possible race condition in task notification waits. * Move task notification wait loop to its own function. * The prvMQTTConnect function was doing more than just connecting, so it was split into more functions. * Minor name changes for clarity. * Add macros for AWS IoT metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is only one source file (
task.h) that uses one single character that can not be encoded using ASCII. Using non-ASCII characters adds no benefit to the source, just makes it more complicated.There are also two documentation files that use non-ASCII characters, which have also been replaced for consistency reasons.
After these changes, the whole FreeRTOS-Kernel project uses simple ASCII encoding!
Test Steps
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.