Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds SemphrGetCountFromISR with QMsgWaitingFromISR #345

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

Rrojas93
Copy link
Contributor

@Rrojas93 Rrojas93 commented Jun 7, 2021

Adds uxSemaphoreGetCountFromISR using uxQueueMessagesWaitingFromISR

Description

Noticed this ISR function was missing but the function it wraps (non-ISR ..GetCount function) does contain an ISR friendly prototype.

Test Steps

NA

Related Issue

NA

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Rrojas93 Rrojas93 requested a review from a team as a code owner June 7, 2021 02:29
RichardBarry
RichardBarry previously approved these changes Jun 8, 2021
aggarg
aggarg previously approved these changes Jun 8, 2021
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@aggarg aggarg dismissed stale reviews from RichardBarry and themself via 7edcfc6 June 8, 2021 21:49
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #345 (7edcfc6) into main (eec4233) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files           4        4           
  Lines        1272     1272           
  Branches      342      342           
=======================================
  Hits         1172     1172           
  Misses         53       53           
  Partials       47       47           
Flag Coverage Δ
unittests 92.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec4233...7edcfc6. Read the comment docs.

@Rrojas93
Copy link
Contributor Author

Rrojas93 commented Jun 8, 2021

Haven't had a chance to look at this again until now.

I'm curious, this was failing a spell check on the function name so we add the name to the lexicon file which seems to be a "vocabulary" list of words it checks against? Want to make sure I know for any future contributions.

Thanks!

@aggarg
Copy link
Member

aggarg commented Jun 8, 2021

Haven't had a chance to look at this again until now.

I'm curious, this was failing a spell check on the function name so we add the name to the lexicon file which seems to be a "vocabulary" list of words it checks against? Want to make sure I know for any future contributions.

Thanks!

Yes, that's correct. Here are the steps done as part of spell check: https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/.github/workflows/ci.yml#L9

Thanks.

@aggarg aggarg merged commit bad8f01 into FreeRTOS:main Jun 9, 2021
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants