Skip to content

Prior Connection Command #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 26, 2015
Merged

Prior Connection Command #562

merged 6 commits into from
Apr 26, 2015

Conversation

antenore
Copy link
Member

A command that can be executed just before any connection.
Fixes #553 , requested in the #520 issue by @BrainwreckedTech

Can you please test/destroy/critics and let me know?

@giox069

@BrainwreckedTech
Copy link

AWESOME! This works.

I noticed is that I needed to specify full paths. For me, that's an, "Oh well." But along with I think I ran into a text entry limit when editing the command.

I don't know where the logic error lies in this next one.

The proper command (the one that works as expected) is:

/usr/bin/sudo /scr/qcl -w -x 50 -m 512 -p /mnt/qvm/clib-arch.img -t /usr/bin/konsole

But when I try:

/usr/bin/konsole "/usr/bin/sudo /scr/qcl -w -x 50 -m 512 -p /mnt/qvm/clib-arch.img"

I get the old, dreaded, immediate, "VNC connection failed." What's expected is that the command should wait up until the timeout because konsole isn't going to exit. The same goes for xterm.

Konsole fails with:

QCoreApplication::arguments: Please instantiate the QApplication object first
QDBusConnection: session D-Bus connection created before QCoreApplication. Application may misbehave.
QDBusConnection: session D-Bus connection created before QCoreApplication. Application may misbehave.

Xterm fails with:

/usr/bin/xterm: No absolute path found for shell: /usr/bin/sudo /scr/qcl -w -x 50 -m 512 -p /mnt/qvm/clib-arch.img

@antenore
Copy link
Member Author

Thanks for the test. Let me take a look and I'll fix it.

@antenore
Copy link
Member Author

Just a note... Considering my dev skills, this is a quite big amount of job to do for me.
In the meanwhile try to put your commands in a shell script, it should work.

@antenore
Copy link
Member Author

@BrainwreckedTech

I've done some improvements.

  • Tooltip
  • Search path (it uses PATH environment variable)
  • Even if the command is not valid, remmina willl try to start the connection (it must be this way IMHO)

antenore added a commit that referenced this pull request Apr 26, 2015
@antenore antenore merged commit 34fa463 into next Apr 26, 2015
@antenore antenore deleted the preexec branch June 21, 2015 20:49
@antenore antenore restored the preexec branch June 21, 2015 20:49
@antenore antenore deleted the preexec branch June 21, 2015 20:49
antenore added a commit that referenced this pull request Jul 10, 2015
antenore added a commit that referenced this pull request Jul 10, 2015
antenore added a commit that referenced this pull request Jul 10, 2015
antenore added a commit that referenced this pull request Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants