-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve __NEXT_DATA__ for userData #180
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Original review guide in EnglishReviewer's Guide by SourceryThis pull request addresses an issue where user data was not being correctly resolved due to changes in the website's data structure. The changes include adding logic to parse the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dragon-fish - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why both legacy and next data resolvers are needed.
- The error handling in
resolveNextData
could be improved by checking ifnextData?.props?.pageProps?.serverSerializedPreloadedState
exists before parsing.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sourcery 总结
Bug 修复:
Original summary in English
Summary by Sourcery
Bug Fixes: