Removing Forever dependency #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
requested changes
Oct 10, 2017
bin/ungit
Outdated
| }); | ||
| var child = child_process.spawn('node', | ||
| [path.join(__dirname, '..', 'src', 'server.js')].concat(process.argv.slice(2)), | ||
| { cwd: path.join(process.cwd(), '..') } |
There was a problem hiding this comment.
What about the env setting?
There was a problem hiding this comment.
It didn't seems to be respected as apparent by #959. I may leave it in with a note though...
| var child = new (forever.Monitor)(path.join(__dirname, '..', 'src', 'server.js'), { | ||
| silent: false, | ||
| minUptime: 2000, | ||
| max: config.maxNAutoRestartOnCrash, |
There was a problem hiding this comment.
Is maxNAutoRestartOnCrash used anywhere else?
There was a problem hiding this comment.
Not really... From my tests forever monitor actually never kicked in and process didn't die during errors. Errors seems to be captured and handled so..
There was a problem hiding this comment.
Ok, so that means the config setting can be removed.
campersau
reviewed
Oct 11, 2017
CHANGELOG.md
Outdated
| @@ -3,7 +3,9 @@ All notable changes to this project will be documented in this file. | |||
| This project adheres to [Semantic Versioning](http://semver.org/). | |||
| Use the following format for additions: ` - VERSION: [feature/patch (if applicable)] Short description of change. Links to relevant issues/PRs.` | |||
|
|
|||
| - 1.1.31: Bump dependencies | |||
| - 1.1.31: | |||
There was a problem hiding this comment.
Also bump version in package.json.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This was referenced Oct 21, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will try to refactor it to es6 without async.