Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionend in #1296 (comment) here is the github workflow for running tests on push and pull requests and uploading electron packages as artifacts.
This also removes the artifact publishing from appveyor because it is no longer needed and they had issues running on macos #1241 (comment).
I have run them for quite some time and the windows / macos builds are a bit flaky.
On windows the tests sometimes fail in
Auto checkout on branch creation.
On macos it sometings hangs during packaging.