Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clearing gitignore file #1236

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Enable clearing gitignore file #1236

merged 1 commit into from
Nov 3, 2019

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Nov 3, 2019

Currently it is not possible to remove all content from the .gitignore file as an empty string request is considered invalid by the server.

  • Allow empty string requests for gitignore
  • Extend test to cover empty string
  • Return 400 instead of 500 for invalid requests (not a server issue)
  • Fix lint issues in gitignore function

@campersau campersau merged commit 555ab89 into FredrikNoren:master Nov 3, 2019
@Hirse Hirse deleted the gitignore-empty branch November 3, 2019 21:20
@campersau campersau mentioned this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants