Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide diff-buttons on commit hover #1225

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Hide diff-buttons on commit hover #1225

merged 2 commits into from
Oct 30, 2019

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Oct 22, 2019

  • Show the diff buttons only when a commit is selected, but not on hover
  • Remove empty space when no commit message body is present
  • Align margins in the commit-"card"
  • Clean up lint issues in changed files

Before
image

After
image

@campersau
Copy link
Collaborator

While validating these changes I have noticed that there are other inconsitencies as well. Maybe not related to the PR but if you are working on it maybe you can fix them as well. Otherwise we can create separate issues for them.

The order and state of the buttons are inconsistent:
image

Clicking on the No Wrap button also toggles the visual state of the Show/Ignore white space diff button:
image

@Hirse
Copy link
Contributor Author

Hirse commented Oct 24, 2019

@campersau I have noticed some of that too, but don't think they are related.
I can change it in a new PR.

btw, do you know why the tests in Travis seem to consistently fail (even before my PRs)?

@campersau campersau merged commit 4ba7e9a into FredrikNoren:master Oct 30, 2019
@Hirse Hirse deleted the diff-buttons branch October 30, 2019 17:34
@campersau campersau mentioned this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants