Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS review] GoogleColab example does not show plots #15

Open
KedoKudo opened this issue Nov 28, 2023 · 3 comments
Open

[JOSS review] GoogleColab example does not show plots #15

KedoKudo opened this issue Nov 28, 2023 · 3 comments
Assignees

Comments

@KedoKudo
Copy link

This is part of the review feedback for JOSS submission (openjournals/joss-reviews#6024)

After clicking the link to Google collab and running through the two cells. The widget shows up, but the generate plot button does not trigger the simulation and generate corresponding plots.

@FrederikLizakJohansen
Copy link
Owner

Thank you for bringing this to our attention, and we appreciate your patience. (Happy New Year!)

We have investigated the issue you reported regarding the "generate plot" button not triggering the simulation in Google Colab. To combat this issue, we have updated the "interact" function so that it is now possible to upload and download data-files more easily. This, however, have introduced some additional challenges. Colab is now flagging the "interact" widget as a "third-party-widget," causing the generate plot button to malfunction. Currently, the only known solution is to downgrade the "Ipywidgets" version, but this may lead to other components breaking.

In light of these difficulties, we have decided to reserve the implementation of the "interact" function on HuggingFace for a future version. Meanwhile, we recommend users to pip install versions <1.0.5 of the DebyeCalculator specifically for Colab usage, where data-files (xyz or cif) can be manually uploaded to Colab, and the widget can access them using the now deprecated path string option. If you want to test this out, you can clone the repository and manually upload the "data" folder to the Colab page. You should then be able to generate the corresponding plots shown on the figure in the paper.

We understand that this workaround is not ideal, and we apologize for any inconvenience caused. We are actively working on addressing this issue and appreciate your understanding. We will keep this issue open until we find a sustainable solution. If you have any further questions or concerns, please feel free to reach out.

Thank you again for your contribution and understanding.

@KedoKudo
Copy link
Author

Thanks for looking into this. Could you link this issue in the notebook so that users are aware of this issue? The current workaround solution looks reasonable, and users should be aware of this workaround when launching this notebook in Collab.

@FrederikLizakJohansen
Copy link
Owner

Thanks again for the suggestion. We've incorporated the link with a brief message in the Colab notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants