Hotfix: change \newpage to \clearpage #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yung-Wen noticed an issues with two figures being crammed onto the same page and running off the page when using the latest VISCtemplates to render a previous PT report. I was able to reproduce the issue and trace it to a limitation of the \newpage command that is now being used by insert_break(). Changing \newpage to \clearpage resolves the issue.
Helpful explanation of the differences between \newpage and \clearpage: https://tex.stackexchange.com/questions/497746/comparison-between-newpage-clearpage-and-pagebreak-etc
Checklist
devtools::document